remove operational limits groups #113
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Etienne LESOT <[email protected]>
Signed-off-by: Etienne LESOT <[email protected]>
basseche
reviewed
Oct 22, 2025
src/main/java/org/gridsuite/modification/modifications/AbstractBranchModification.java
Outdated
Show resolved
Hide resolved
basseche
reviewed
Oct 22, 2025
src/main/java/org/gridsuite/modification/modifications/AbstractBranchModification.java
Outdated
Show resolved
Hide resolved
basseche
reviewed
Oct 22, 2025
src/test/java/org/gridsuite/modification/modifications/LineModificationTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Etienne LESOT <[email protected]>
basseche
previously approved these changes
Oct 23, 2025
Signed-off-by: Etienne LESOT <[email protected]>
Signed-off-by: Etienne LESOT <[email protected]>
basseche
reviewed
Oct 29, 2025
| private void removeOlg(Branch<?> branch, OperationalLimitsGroupModificationInfos opLGModificationInfos, List<ReportNode> operationalLimitsGroupReports, OperationalLimitsGroupInfos.Applicability applicability) { | ||
| if (applicability == SIDE1 && branch.getOperationalLimitsGroup1(opLGModificationInfos.getId()).isEmpty() || | ||
| applicability == SIDE2 && branch.getOperationalLimitsGroup2(opLGModificationInfos.getId()).isEmpty()) { | ||
| throw new PowsyblException("Cannot delete operational limit group " + opLGModificationInfos.getId() + " which has not been found in equipment on side " + applicability); |
There was a problem hiding this comment.
are you sur we should throw here ? Why not just log an error ?
Mathieu-Deharbe
requested changes
Oct 29, 2025
Comment on lines
+337
to
+346
| line.newOperationalLimitsGroup1("NewLimitsGroup2").newCurrentLimits() | ||
| .setPermanentLimit(10.0) | ||
| .add(); | ||
| // side 2 | ||
| line.newOperationalLimitsGroup2("NewLimitsGroup1").newCurrentLimits() | ||
| .setPermanentLimit(10.0) | ||
| .add(); | ||
| line.newOperationalLimitsGroup2("NewLimitsGroup3").newCurrentLimits() | ||
| .setPermanentLimit(10.0) | ||
| .add(); |
There was a problem hiding this comment.
Is there a reason for "NewLimitsGroup2" and "NewLimitsGroup3" to have 2 different names ? Wouldn't it be more useful to have the same name in order to check that the DELETE correctly handle the applicability and doesn't delete both ?
|
Mathieu-Deharbe
requested review from
Mathieu-Deharbe
and removed request for
Mathieu-Deharbe
Mathieu-Deharbe
requested review from
Mathieu-Deharbe
and removed request for
Mathieu-Deharbe
Mathieu-Deharbe
approved these changes
Nov 3, 2025
Mathieu-Deharbe
requested review from
Mathieu-Deharbe
and removed request for
Mathieu-Deharbe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.